aboutsummaryrefslogtreecommitdiff
path: root/management/commands/timetables.py
diff options
context:
space:
mode:
authorAlban Gruin2017-09-25 16:08:01 +0200
committerAlban Gruin2017-09-25 16:08:01 +0200
commitaa7ccf13a8735f162e2ea859ad1d8ebe9f34f657 (patch)
tree686b7782c87b0848d7965d99031977f22110d9d3 /management/commands/timetables.py
parent3d2fa6b15c58b775bc7e60e148f3a6bf1f2631d0 (diff)
Utilisation de pylint pour améliorer la qualité du code
Diffstat (limited to 'management/commands/timetables.py')
-rw-r--r--management/commands/timetables.py19
1 files changed, 13 insertions, 6 deletions
diff --git a/management/commands/timetables.py b/management/commands/timetables.py
index e136f53..f01ac3c 100644
--- a/management/commands/timetables.py
+++ b/management/commands/timetables.py
@@ -13,6 +13,8 @@
# You should have received a copy of the GNU Affero General Public License
# along with celcatsanitizer. If not, see <http://www.gnu.org/licenses/>.
+import datetime
+
from django.core.management.base import BaseCommand
from django.db import transaction
from django.db.models import Max
@@ -22,13 +24,15 @@ from edt.models import Timetable, Course
from edt.utils import get_week
from ._private import delete_courses_in_week, get_events, get_update_date, get_weeks, get_xml
-import datetime
-
@transaction.atomic
def process_timetable_week(timetable, year, week, soup, weeks_in_soup):
begin, end = get_week(year, week)
- last_update_date = Course.objects.filter(timetable=timetable, begin__gte=begin, begin__lt=end).aggregate(Max("last_update"))["last_update__max"]
+ last_update_date = Course.objects.filter(timetable=timetable,
+ begin__gte=begin,
+ begin__lt=end) \
+ .aggregate(Max("last_update")) \
+ ["last_update__max"]
new_update_date = get_update_date(soup)
if last_update_date is not None and new_update_date is not None and \
@@ -38,7 +42,9 @@ def process_timetable_week(timetable, year, week, soup, weeks_in_soup):
delete_courses_in_week(timetable, year, week)
for name, type_, groups, rooms, notes, begin, end in \
get_events(timetable, year, week, soup, weeks_in_soup):
- course = Course.objects.create(timetable=timetable, begin=begin, end=end)
+ course = Course.objects.create(timetable=timetable,
+ begin=begin,
+ end=end)
course.name = name
course.type = type_
course.notes = notes
@@ -86,8 +92,9 @@ class Command(BaseCommand):
try:
process_timetable(timetable, year, weeks)
- except Exception as e:
- self.stderr.write(self.style.ERROR("Failed to process {0}: {1}".format(timetable, e)))
+ except Exception as exc:
+ self.stderr.write(
+ self.style.ERROR("Failed to process {0}: {1}".format(timetable, exc)))
errcount += 1
if errcount == 0: